Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates (primarily React 17 and React Native 0.64.2) #147

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Dependency updates (primarily React 17 and React Native 0.64.2) #147

wants to merge 6 commits into from

Conversation

inderdhir
Copy link

No description provided.

@smithydll
Copy link

I don't think React Native dependency version needs to be updated, Expo has only just upgraded to 0.64.2 and this module works fine on older versions.
Just needs React dependency changed to

"react": "^16.2.0 || ^17 || ^18"

@baochungit
Copy link

Please consider to merge it. Thanks!

@JavanHuang
Copy link

This is blocking the install of react-native-markdown-display on v0.66.3 of react-native, which requires v17.0.2 of react whenever we run npm install. It would be great if we could get this merged.

Alternatively, if anyone requires the 17.0.2 react update urgently, I found another package here that was forked from this repository updated with the changes in this PR: https://www.npmjs.com/package/@flowchase/react-native-markdown-display.

@nicobermudez
Copy link

Bump

@HugDoggyDogg
Copy link

Bump. Could really use this change

@inderdhir
Copy link
Author

Just updated React/RN deps

@nicobermudez
Copy link

Can we merge this?

@Gnative
Copy link

Gnative commented Sep 7, 2022

Merge please

@jkester1986
Copy link

@iamacup can we get this merged?

@NilsBaumgartner1994
Copy link

push

@chrisglein chrisglein mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@inderdhir @smithydll @baochungit @JavanHuang @nicobermudez @HugDoggyDogg @Gnative @jkester1986 @NilsBaumgartner1994